-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize Eq implementation for paths #86179
Conversation
Filesystems generally have a tree-ish structure which means paths are more likely to share a prefix than a suffix. Absolute paths are especially prone to share long prefixes.
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
@rustbot label T-libs-impl |
@bors r+ rollup=never |
📌 Commit 53d71c1 has been approved by |
⌛ Testing commit 53d71c1 with merge 0041ef71d6a83e496a616867e6fbe52097b67a2c... |
💔 Test failed - checks-actions |
looks like a spurious error. @bors retry |
☀️ Test successful - checks-actions |
Filesystems generally have a tree-ish structure which means paths are more likely to share a prefix than a suffix. Absolute paths are especially prone to share long prefixes.
quick benchmark consisting of a search through through a vec containing the absolute paths of all (1850) files in
compiler/
: