Report an error if resolution of closure call functions failed #86249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
varkor
reviewed
Jun 30, 2021
Comment on lines
598
to
599
| "make sure the `fn`/`fn_mut`/`fn_once` lang items are defined \ | ||
| and have an associated `call`/`call_mut`/`call_once` function", |
There was a problem hiding this comment.
Suggested change
| "make sure the `fn`/`fn_mut`/`fn_once` lang items are defined \ | |
| and have an associated `call`/`call_mut`/`call_once` function", | |
| "make sure the `fn`/`fn_mut`/`fn_once` lang items are defined \ | |
| and have associated `call`/`call_mut`/`call_once` functions", |
Just to make sure the plurals match up.
There was a problem hiding this comment.
Fixed. Thanks for the review!
|
This looks good. r=me after tweaking the wording. Sorry for taking so long to get to this. |
varkor
added
S-waiting-on-author
|
Thanks! @bors r+ |
|
📌 Commit dab25ab has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jul 11, 2021
Report an error if resolution of closure call functions failed This pull request fixes rust-lang#86238. The current implementation seems to assume that resolution of closure call functions (I'm not sure what the proper term is; I mean `call` of `Fn` etc.) can never fail: https://github.com/rust-lang/rust/blob/60f1a2fc4b535ead9c85ce085fdce49b1b097531/compiler/rustc_typeck/src/check/callee.rs#L590-L595 But actually, it can, if the `fn`/`fn_mut`/`fn_once` lang items are not defined, or don't have an associated `call`/`call_mut`/`call_once` function, leading to the ICE described in rust-lang#86238. I have therefore turned the `span_bug!()` into an error message, which prevents the ICE.
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #86238. The current implementation seems to assume that resolution of closure call functions (I'm not sure what the proper term is; I mean
callofFnetc.) can never fail:rust/compiler/rustc_typeck/src/check/callee.rs
Lines 590 to 595 in 60f1a2f
But actually, it can, if the
fn/fn_mut/fn_oncelang items are not defined, or don't have an associatedcall/call_mut/call_oncefunction, leading to the ICE described in #86238. I have therefore turned thespan_bug!()into an error message, which prevents the ICE.