Skip to content

fix port parsing in extra::url::from_str #8630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mihneadb
Copy link
Contributor

Before this PR,

extern mod extra;
use extra::url;

fn main() {
    let str = ~"http://localhost:8000";
    let url = url::from_str(str);
    printfln!("%?", url);
}

yields

Ok({scheme: ~"http", user: None, host: ~"localhost", port: Some(~"800"), path: ~"", query: ~[], fragment: None})

After, we get:

Ok({scheme: ~"http", user: None, host: ~"localhost", port: Some(~"8000"), path: ~"", query: ~[], fragment: None})

@mihneadb
Copy link
Contributor Author

Dupe of #8616 . Closing.

@mihneadb mihneadb closed this Aug 20, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 7, 2022
Add lints `drop_non_drop` and `forget_non_drop`

fixes rust-lang#1897

changelog: Add lints `drop_non_drop` and `forget_non_drop`
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant