Skip to content

[stable] 1.53.0 release - backport #86390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

Mark-Simulacrum
Copy link
Member

This hopefully fixes a Clippy ICE on rustc std and the crates.io codebase (and potentially
others).

r? @Mark-Simulacrum

This fixes a Clippy ICE on rustc std and the crates.io codebase (and potentially
others).
@rust-highfive
Copy link
Contributor

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2021
@Mark-Simulacrum
Copy link
Member Author

Cherry-picking subtree commits seems not possible via git-cherry-pick, so I just generated a new commit based on the small diff of 572c405. That merged in #84980 which will be in 1.54.0, so we don't need a beta backport or similar here.

It's not clear that we will release this backport but given the short timeline I'm trying to get artifacts by tomorrow morning; we can make a decision whether to use them (or not) then.

@bors r+ rollup=never p=100

@bors
Copy link
Collaborator

bors commented Jun 17, 2021

📌 Commit 8e78f4a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2021
@bors
Copy link
Collaborator

bors commented Jun 17, 2021

⌛ Testing commit 8e78f4a with merge 53cb7b0...

@bors
Copy link
Collaborator

bors commented Jun 17, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 53cb7b0 to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 17, 2021
@bors bors merged commit 53cb7b0 into rust-lang:stable Jun 17, 2021
@rustbot rustbot added this to the 1.53.0 milestone Jun 17, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the stable-next branch June 17, 2021 11:15
@Lofterheit
Copy link

Martial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants