Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: add optional woff2 versions of Source Serif and Source Code #86402

Merged
merged 2 commits into from
Jun 22, 2021
Merged

rustdoc: add optional woff2 versions of Source Serif and Source Code #86402

merged 2 commits into from
Jun 22, 2021

Conversation

tspiteri
Copy link
Contributor

This provides woff2 versions of Source Serif and Source Code similar to how #82545 provides woff2 versions of Fira Sans. The total byte count for the six files (three for each font family) is reduced by 25% from 476 KiB to 358 KiB.

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2021
@GuillaumeGomez
Copy link
Member

Looks good to me but considering how complicated font updates were in the past, I'll ask our expert to review. :)

r? @jsha

@rust-highfive rust-highfive assigned jsha and unassigned GuillaumeGomez Jun 17, 2021
@jsha
Copy link
Contributor

jsha commented Jun 20, 2021

I've confirmed that the SourceCodePro files are identical with the ones from https://github.com/adobe-fonts/source-code-pro/releases/tag/2.038R-ro%2F1.058R-it%2F1.018R-VAR, and that the SourceSerif4 files are identical with the ones from https://github.com/adobe-fonts/source-serif. And all the diffs seem to be correct. 👍🏻 Thanks for making this change, @tspiteri.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 20, 2021

📌 Commit a7d2061 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2021
@bors
Copy link
Contributor

bors commented Jun 20, 2021

⌛ Testing commit a7d2061 with merge c262790f0666dc107cc85cdf6622efe250eb8689...

@bors
Copy link
Contributor

bors commented Jun 20, 2021

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2021
@tspiteri
Copy link
Contributor Author

I cannot interpret the logs and have no idea why CI failed.

@jsha
Copy link
Contributor

jsha commented Jun 22, 2021 •
edited
Loading

I also don't understand the test failure logs. Perhaps it is an intermittent failure? Let's retry:

@bors try

Also cc @jyn514 any idea why the tests failed above?

@bors
Copy link
Contributor

bors commented Jun 22, 2021

⌛ Trying commit a7d2061 with merge fc68d26a2d1c15d7eeddc9fda066cc1afe2df94e...

@jyn514
Copy link
Member

jyn514 commented Jun 22, 2021

Failed without logs, the apple machine must have been reallocated in the middle of a build.

@bors retry

image

@bors
Copy link
Contributor

bors commented Jun 22, 2021

⌛ Trying commit a7d2061 with merge e9b470e60b35770edf3072a8c057575129dcc219...

@jyn514
Copy link
Member

jyn514 commented Jun 22, 2021

@jsha note that bors try is different, it only builds artifacts but does not merge the PR. It's usually used for perf runs, or occasionally if people need to download changes with rustup before they've been merged.

@jyn514
Copy link
Member

jyn514 commented Jun 22, 2021

@bors r- r=jsha

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2021
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 22, 2021
@bors
Copy link
Contributor

bors commented Jun 22, 2021

📌 Commit a7d2061 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2021
@bors
Copy link
Contributor

bors commented Jun 22, 2021

☀️ Test successful - checks-actions
Approved by: jsha
Pushing e9b470e60b35770edf3072a8c057575129dcc219 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 22, 2021
@bors
Copy link
Contributor

bors commented Jun 22, 2021

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@jyn514
Copy link
Member

jyn514 commented Jun 22, 2021

@rust-lang/infra I think we confused bors, do you know how to fix it?

@kennytm
Copy link
Member

kennytm commented Jun 22, 2021

@bors retry

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 22, 2021
@JohnTitor
Rollup merge of rust-lang#86402 - tspiteri:source-woff2, r=jsha
6adabc8 
rustdoc: add optional woff2 versions of Source Serif and Source Code

This provides woff2 versions of Source Serif and Source Code similar to how rust-lang#82545 provides woff2 versions of Fira Sans. The total byte count for the six files (three for each font family) is reduced by 25% from 476 KiB to 358 KiB.
@JohnTitor JohnTitor mentioned this pull request Jun 22, 2021
Closed
@JohnTitor JohnTitor removed the merged-by-bors This PR was explicitly merged by bors. label Jun 22, 2021
@JohnTitor JohnTitor mentioned this pull request Jun 22, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2021
@bors
Auto merge of rust-lang#86545 - JohnTitor:rollup-7sqdhpa, r=JohnTitor
3487be1 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#86393 (Add regression test for issue rust-lang#52025)
 - rust-lang#86402 (rustdoc: add optional woff2 versions of Source Serif and Source Code)
 - rust-lang#86451 (Resolve intra-doc links in summary desc)
 - rust-lang#86501 (Cleanup handling of `crate_name` for doctests)
 - rust-lang#86517 (Fix `unused_unsafe` around `await`)
 - rust-lang#86537 (Mark some edition tests as check-pass)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fd96d55 into rust-lang:master Jun 22, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 22, 2021
@tspiteri tspiteri deleted the source-woff2 branch July 7, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsha jsha

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
10 participants
@tspiteri @rust-highfive @GuillaumeGomez @jsha @bors @rust-log-analyzer @jyn514 @kennytm @JohnTitor @rustbot