Add clobber-only register classes for asm! #86416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
JohnCSimon
added
F-rust_2018_preview
|
r? @nagisa |
nagisa
reviewed
Jul 8, 2021
| @@ -199,6 +199,19 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> { | |||
| } | |||
| ); | |||
|
|
|||
| // Some register classes can only be used as clobbers. | |||
| if reg_class.is_clobber_only(asm_arch.unwrap()) | |||
| && (!is_clobber || matches!(reg, asm::InlineAsmRegOrRegClass::RegClass(_))) | |||
There was a problem hiding this comment.
I'm not following what purpose the matches!(reg, asm::InlineAsmRegOrRegClass::RegClass(_)) part is serving. Could you explain and/or add a comment?
| v28: vreg = ["v28", "b28", "h28", "s28", "d28", "q28", "z28"], | ||
| v29: vreg = ["v29", "b29", "h29", "s29", "d29", "q29", "z29"], | ||
| v30: vreg = ["v30", "b30", "h30", "s30", "d30", "q30", "z30"], | ||
| v31: vreg = ["v31", "b31", "h31", "s31", "d31", "q31", "z31"], |
There was a problem hiding this comment.
If I understand this correctly, the addition of z registers is not strictly related to the clobber-only register classes, correct? While related to the p registers, I don't believe p registers are required to utilize the z registers, right?
If that's the case, could this become a separate commit?
nagisa
added
S-waiting-on-author
These are needed to properly express a function call ABI using a clobber list, even though we don't support passing actual values into/out of these registers.
Amanieu
force-pushed
the
asm_clobber_only
branch
from
5ede032 to
d2a1d04
Compare
Amanieu
added
S-waiting-on-review
|
@bors r+ Thanks! |
|
📌 Commit d2a1d04 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed to properly express a function call ABI using a clobber
list, even though we don't support passing actual values into/out of
these registers.