Skip to content

Lint for unused borrows as part of UNUSED_MUST_USE #86426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jun 18, 2021

close #76264

base on #76894

r? @RalfJung

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2021
@RalfJung
Copy link
Member

Thanks for the PR!

I'm sorry, but I am pretty swamped currently and this is not in my core area of expertise.
@rust-lang/compiler could someone else take over reviewing this?

@Rustin170506 Rustin170506 requested a review from flip1995 June 18, 2021 08:21
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy changes LGTM

@Aaron1011
Copy link
Member

r? @Aaron1011

@rust-highfive rust-highfive assigned Aaron1011 and unassigned RalfJung Jun 18, 2021
@Aaron1011
Copy link
Member

The FCP previously completed in #76894 (comment).

Code LGTM.

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 18, 2021

📌 Commit 884336e has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 19, 2021
…=Aaron1011

Lint for unused borrows as part of UNUSED_MUST_USE

close rust-lang#76264

base on rust-lang#76894

r? `@RalfJung`
@bors
Copy link
Collaborator

bors commented Jun 19, 2021

⌛ Testing commit 884336e with merge 39260f6...

@bors
Copy link
Collaborator

bors commented Jun 19, 2021

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 39260f6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 19, 2021
@bors bors merged commit 39260f6 into rust-lang:master Jun 19, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 19, 2021
@Rustin170506 Rustin170506 deleted the rustin-patch-lint-warn branch June 19, 2021 11:38
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 1, 2021
…aron1011

Lint for unused borrows as part of UNUSED_MUST_USE

close rust-lang#76264

base on rust-lang#76894

r? `@RalfJung`
narpfel added a commit to narpfel/tree-sitter that referenced this pull request Aug 14, 2021
This produces an `unused_must_use` warning on nightly:
rust-lang/rust#86426
hendrikvanantwerpen pushed a commit to hendrikvanantwerpen/tree-sitter that referenced this pull request Nov 23, 2021
This produces an `unused_must_use` warning on nightly:
rust-lang/rust#86426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when a borrow expression is unused
7 participants