Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump expat to 2.4.1 #86573

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Bump expat to 2.4.1 #86573

merged 1 commit into from
Jun 23, 2021

Conversation

Mark-Simulacrum
Copy link
Member

Temporary fix as expat 2.3.0 is now renamed, presumably due to https://github.com/libexpat/libexpat/blob/R_2_4_1/expat/Changes#L19.

r? @pietroalbini

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2021
@pietroalbini
Copy link
Member

r=me

Given upstream's habit of breaking links I'd be tempted to mirror this on our bucket to prevent breakages from happening in the future. In the diff I see a CT_EXPAT_MIRRORS variable: I'd prefer for the files to be mirrored in ci-mirrors.rlo in the long term, up to you whether you want to do it in this PR or whether we should followup with that later.

@Mark-Simulacrum
Copy link
Member Author

I am wary of just doing that -- in both cases where this has happened, it is a security-related fix. I'm not clear on whether that even could affect us (I imagine no, but not sure). Given our story there is not wonderful, I think mirroring is a little premature just now without some more work.

@bors r=pietroalbini

@bors
Copy link
Contributor

bors commented Jun 23, 2021

📌 Commit 9fc77e2 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2021
@bors
Copy link
Contributor

bors commented Jun 23, 2021

⌛ Testing commit 9fc77e2 with merge 5a78340...

@ehuss ehuss mentioned this pull request Jun 23, 2021
Merged
This was referenced Jun 23, 2021
Merged
Merged
@bors
Copy link
Contributor

bors commented Jun 23, 2021

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 5a78340 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 23, 2021
@bors bors merged commit 5a78340 into rust-lang:master Jun 23, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 23, 2021
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jun 24, 2021
@m-ou-se
Rollup merge of rust-lang#86583 - dns2utf8:use_https, r=pietroalbini
6041a32 
Use https for sourceforge during CI

I saw that we use http during CI opening up the CI process to on the wire tampering.

based on rust-lang#86573

r? `@pietroalbini`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 25, 2021
@bors
Auto merge of rust-lang#86583 - dns2utf8:use_https, r=pietroalbini
4733f32 
Use https for sourceforge during CI

I saw that we use http during CI opening up the CI process to on the wire tampering.

based on rust-lang#86573

r? `@pietroalbini`
@Mark-Simulacrum Mark-Simulacrum deleted the expat-bump branch June 29, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @pietroalbini @bors @rust-highfive @rustbot