Fix future_prelude_collision
false positive
#86657
Merged
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86633
The lint for checking if method resolution of methods named
try_into
will fail in 2021 edition previously would fire on all inherent methods, however for inherent methods that consumeself
, this takes priority overTryInto::try_into
due to being inherent, while trait method and methods that take&self
or&mut self
don't take priority, and thus aren't affected by this false positive.This fix is rather simple: simply checking if the inherent method doesn't auto-deref or auto-ref (and thus takes
self
) and if so, prevents the lint from firing.