fix(rustdoc): generics search #86659

notriddle · 2021-06-27T06:05:24Z

This commit adds a test case for generics, re-adds generics data
to the search index, and tweaks function indexing to use less space in JSON.

This partially reverts commit 14ca894.

rust-highfive · 2021-06-27T06:05:26Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

rust-highfive · 2021-06-27T06:05:27Z

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

notriddle · 2021-06-27T06:05:57Z

r? @GuillaumeGomez #86648

notriddle · 2021-06-28T04:07:42Z

@rustbot label: +A-rustdoc-js

src/librustdoc/html/static/search.js

GuillaumeGomez · 2021-06-28T11:48:10Z

Overall looks good to me, thanks a lot for this fix! Just one thing: you can put multiple search index tests into one file (like it's done in here). I made this comment because: can you add a test where you only look for the generic parameter please?

GuillaumeGomez · 2021-06-28T11:48:40Z

Also: I'll need to make a perf run because some types' increased, so we have a track of it.

notriddle · 2021-06-28T16:30:40Z

I made this comment because: can you add a test where you only look for the generic parameter please?

Sure. generics and generics-trait now both check with the "just the parameter" case.

src/librustdoc/html/render/mod.rs

src/librustdoc/html/render/cache.rs

src/librustdoc/html/render/mod.rs

src/librustdoc/html/render/cache.rs

src/librustdoc/html/static/search.js

…=notriddle Fix rustdoc query type filter I realized while reviewing rust-lang#86659 that the type filter was broken on search so I'd prefer it to get merged before merging rust-lang#86659. r? `@notriddle`

GuillaumeGomez · 2021-07-01T08:12:36Z

Can you rebase on master now that #86746 was merged please?

This commit adds a test case for generics, re-adds generics data to the search index, and tweaks function indexing to use less space in JSON. This reverts commit 14ca894.

notriddle · 2021-07-01T14:08:44Z

@GuillaumeGomez kay, it's rebased

GuillaumeGomez · 2021-07-01T14:14:02Z

Thanks! Considering that the number of changes on the rustdoc "backend" side is now very small, I don't think we need to run a perf check anymore. r=me once CI pass.

notriddle · 2021-07-01T14:44:15Z

@bors r=GuillaumeGomez

bors · 2021-07-01T14:44:16Z

@notriddle: 🔑 Insufficient privileges: Not in reviewers

GuillaumeGomez · 2021-07-01T14:46:49Z

@bors: r+

bors · 2021-07-01T14:46:50Z

📌 Commit cedd242 has been approved by GuillaumeGomez

…c, r=GuillaumeGomez fix(rustdoc): generics search This commit adds a test case for generics, re-adds generics data to the search index, and tweaks function indexing to use less space in JSON. This partially reverts commit 14ca894.

Rollup of 7 pull requests Successful merges: - rust-lang#86148 (Check the number of generic lifetime and const parameters of intrinsics) - rust-lang#86659 (fix(rustdoc): generics search) - rust-lang#86768 (Add myself to mailmap) - rust-lang#86775 (Test for const trait impls behind feature gates) - rust-lang#86779 (Allow anyone to add or remove any label starting with perf-) - rust-lang#86783 (Move Mutex::unlock to T: ?Sized) - rust-lang#86785 (proc_macro/bridge: Remove dead code Slice type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned CraftSpider Jun 27, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2021

rust-highfive assigned GuillaumeGomez and unassigned CraftSpider Jun 27, 2021

This comment has been minimized.

Sign in to view

notriddle force-pushed the notriddle/generics-rustdoc branch from ca85dbc to a2b9665 Compare June 28, 2021 03:58

rustbot added the A-rustdoc-js Area: Rustdoc's JS front-end label Jun 28, 2021

GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 28, 2021