Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce -Zprofile-closures to evaluate the impact of 2229 #86695

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

arora-aman
Copy link
Member

@arora-aman arora-aman commented Jun 28, 2021

This creates a CSV with name "closure_profile_XXXXX.csv", where the
variable part is the process id of the compiler.

To profile a cargo project you can run one of the following depending on
if you're compiling a library or a binary:

cargo +nightly rustc --lib -- -Zprofile-closures
cargo +nightly rustc --bin {binary_name} -- -Zprofile-closures

r? @nikomatsakis

This creates a CSV with name "closure_profile_XXXXX.csv", where the
variable part is the process id of the compiler.

To profile a cargo project you can run one of the following depending on
if you're compiling a library or a binary:

```
cargo +stage1 rustc --lib -- -Zprofile-closures
cargo +stage1 rustc --bin -- -Zprofile-closures
```
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2021
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2021

📌 Commit fc273e9 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@bors
Copy link
Contributor

bors commented Jun 30, 2021

⌛ Testing commit fc273e9 with merge 868c702...

@bors
Copy link
Contributor

bors commented Jun 30, 2021

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 868c702 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 30, 2021
@bors bors merged commit 868c702 into rust-lang:master Jun 30, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 30, 2021
@arora-aman arora-aman deleted the closure_size branch August 26, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants