Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to indexmap 1.7, using hashbrown 0.11 #86724

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 29, 2021

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2021
@cuviper
Copy link
Member Author

cuviper commented Jun 29, 2021

This may have some perf impact, just as #77566 did when upgrading hashbrown in std.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 29, 2021
@bors
Copy link
Contributor

bors commented Jun 29, 2021

⌛ Trying commit ae9713a with merge 92b0d06901437befe29f756724a7a77968f0ed6d...

@bors
Copy link
Contributor

bors commented Jun 29, 2021

☀️ Try build successful - checks-actions
Build commit: 92b0d06901437befe29f756724a7a77968f0ed6d (92b0d06901437befe29f756724a7a77968f0ed6d)

@rust-timer
Copy link
Collaborator

Queued 92b0d06901437befe29f756724a7a77968f0ed6d with parent e98897e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (92b0d06901437befe29f756724a7a77968f0ed6d): comparison url.

Summary: This change led to significant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -2.0% on full builds of deeply-nested-async-check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 29, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2021

📌 Commit ae9713a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@bors
Copy link
Contributor

bors commented Jun 30, 2021

⌛ Testing commit ae9713a with merge 9af4bde...

@bors
Copy link
Contributor

bors commented Jun 30, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 9af4bde to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 30, 2021
@bors bors merged commit 9af4bde into rust-lang:master Jun 30, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 30, 2021
@cuviper cuviper deleted the indexmap-1.7 branch September 21, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants