-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to indexmap 1.7, using hashbrown 0.11 #86724
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This may have some perf impact, just as #77566 did when upgrading @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ae9713a with merge 92b0d06901437befe29f756724a7a77968f0ed6d... |
☀️ Try build successful - checks-actions |
Queued 92b0d06901437befe29f756724a7a77968f0ed6d with parent e98897e, future comparison URL. |
Finished benchmarking try commit (92b0d06901437befe29f756724a7a77968f0ed6d): comparison url. Summary: This change led to significant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit ae9713a has been approved by |
☀️ Test successful - checks-actions |
No description provided.