-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constify ?-operator for Result and Option #86853
Conversation
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #87237) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b7f572b
to
5f3c830
Compare
This comment has been minimized.
This comment has been minimized.
That might be a bug that I need to fix... |
☔ The latest upstream changes (presumably #87768) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Is there anything more you want me to change :) |
Nope, just got lost in my notifications. Thanks for the reminder. @bors r+ |
📌 Commit 29029c0 has been approved by |
⌛ Testing commit 29029c0 with merge adb022cf36d99ca01304fbe55c13a88086af5278... |
💔 Test failed - checks-actions |
@bors retry |
This comment has been minimized.
This comment has been minimized.
☀️ Test successful - checks-actions |
Finished benchmarking commit (c6007fd): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Revert rust-lang#86853 Should fix issue found in rust-lang#89432
Try to make
?
-operator usable inconst fn
withResult
andOption
, see #74935 . Note that the try-operator itself was constified in #87237.TODO
#![allow(incomplete_features)]
Default
#86808 - I'm not sure~const
in bootstrapping compiler