-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Force projection sub-obligations to EvaluatedToOkModuloRegions
#86871
Conversation
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit e652fe1 with merge 3bb14f64b9b3a5623d1f2357bde65342405b8120... |
☀️ Try build successful - checks-actions |
Queued 3bb14f64b9b3a5623d1f2357bde65342405b8120 with parent 9044245, future comparison URL. |
Finished benchmarking try commit (3bb14f64b9b3a5623d1f2357bde65342405b8120): comparison url. Summary: This change led to significant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @bors rollup=never |
I am a pretty poor reviewer for this change. |
r? rust-lang/compiler |
r? rust-lang/compiler-team |
This seems to be an alternative to #85868, right? I'm not qualified to review this. |
Closing since #85868 was merged. |
No description provided.