Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Force projection sub-obligations to EvaluatedToOkModuloRegions #86871

Closed
wants to merge 1 commit into from

Conversation

Aaron1011
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 4, 2021
@bors
Copy link
Contributor

bors commented Jul 4, 2021

⌛ Trying commit e652fe1 with merge 3bb14f64b9b3a5623d1f2357bde65342405b8120...

@bors
Copy link
Contributor

bors commented Jul 4, 2021

☀️ Try build successful - checks-actions
Build commit: 3bb14f64b9b3a5623d1f2357bde65342405b8120 (3bb14f64b9b3a5623d1f2357bde65342405b8120)

@rust-timer
Copy link
Collaborator

Queued 3bb14f64b9b3a5623d1f2357bde65342405b8120 with parent 9044245, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (3bb14f64b9b3a5623d1f2357bde65342405b8120): comparison url.

Summary: This change led to significant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 9.6% on full builds of deeply-nested-check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-justified along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 5, 2021
@nagisa
Copy link
Member

nagisa commented Jul 10, 2021

I am a pretty poor reviewer for this change.

@nagisa
Copy link
Member

nagisa commented Jul 23, 2021

r? rust-lang/compiler

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021
@jyn514
Copy link
Member

jyn514 commented Aug 15, 2021

r? rust-lang/compiler-team

@michaelwoerister
Copy link
Member

This seems to be an alternative to #85868, right? I'm not qualified to review this.

r? @nikomatsakis

@inquisitivecrystal inquisitivecrystal added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2021
@jackh726
Copy link
Member

jackh726 commented Sep 9, 2021

Closing since #85868 was merged.

@jackh726 jackh726 closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.