-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use all projection sub-obligations during trait evaluation #86896
Conversation
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit bf6052a3b1b74fdf9990f232d842baff862bd21a with merge 2bdc771d8c8b40c585b9a67069f4e8237a0a2316... |
☀️ Try build successful - checks-actions |
Queued 2bdc771d8c8b40c585b9a67069f4e8237a0a2316 with parent 952fdf2, future comparison URL. |
Finished benchmarking try commit (2bdc771d8c8b40c585b9a67069f4e8237a0a2316): comparison url. Summary: This change led to significant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @bors rollup=never |
bf6052a
to
d231eec
Compare
☔ The latest upstream changes (presumably #87375) made this pull request unmergeable. Please resolve the merge conflicts. |
triage: Should this be closed in favor of #85868? |
No description provided.