-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2229 editon feature perf test #86967
Conversation
I just removed teh tests cause it was easier then editing them to make them work again |
I opened this PR to see if removing the edition check in capture analysis code improves any perf. It was one of the possible reasons for the regression noted here: #86588 (comment) |
This comment has been minimized.
This comment has been minimized.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 8a6985d with merge e5523891140a5bed568f2224b9f950288bc2ebf3... |
☀️ Try build successful - checks-actions |
Queued e5523891140a5bed568f2224b9f950288bc2ebf3 with parent ac8c3bf, future comparison URL. |
Finished benchmarking try commit (e5523891140a5bed568f2224b9f950288bc2ebf3): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
r? @ghost