Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2229 editon feature perf test #86967

Closed
wants to merge 1 commit into from
Closed

Conversation

arora-aman
Copy link
Member

r? @ghost

@arora-aman
Copy link
Member Author

I just removed teh tests cause it was easier then editing them to make them work again

@arora-aman
Copy link
Member Author

arora-aman commented Jul 8, 2021

I opened this PR to see if removing the edition check in capture analysis code improves any perf. It was one of the possible reasons for the regression noted here: #86588 (comment)

@rust-log-analyzer

This comment has been minimized.

@the8472
Copy link
Member

the8472 commented Jul 8, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 8, 2021
@bors
Copy link
Contributor

bors commented Jul 8, 2021

⌛ Trying commit 8a6985d with merge e5523891140a5bed568f2224b9f950288bc2ebf3...

@bors
Copy link
Contributor

bors commented Jul 8, 2021

☀️ Try build successful - checks-actions
Build commit: e5523891140a5bed568f2224b9f950288bc2ebf3 (e5523891140a5bed568f2224b9f950288bc2ebf3)

@rust-timer
Copy link
Collaborator

Queued e5523891140a5bed568f2224b9f950288bc2ebf3 with parent ac8c3bf, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (e5523891140a5bed568f2224b9f950288bc2ebf3): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants