Skip to content

Use clang 12.0.1 on dist-x86_64/i686-linux #87019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2021
Merged

Use clang 12.0.1 on dist-x86_64/i686-linux #87019

merged 3 commits into from
Jul 13, 2021
+16 −18

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jul 10, 2021

The LLD + ThinLTO __morestack bug has been fixed in 12.0.1, so
we can now update our clang version. This also means that we no
longer need to build Python 2.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2021
@nikic
Copy link
Contributor Author

nikic commented Jul 10, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 10, 2021
@bors
Copy link
Collaborator

bors commented Jul 10, 2021

⌛ Trying commit 12b081f4beb6840506791c953f97d6f377fcda04 with merge 3997078fb64de7c1f617498940613fcc31ed6102...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 10, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2021
@nikic
Use clang 12.0.1 on dist-x86_64/i686-linux
f29450a 
The LLD + ThinLTO __morestack bug has been fixed in 12.0.1, so
we can now update our clang version. This also means that we no
longer need to build Python 2.
@nikic
Copy link
Contributor Author

nikic commented Jul 10, 2021

@bors try

@bors
Copy link
Collaborator

bors commented Jul 10, 2021

⌛ Trying commit f29450a with merge ff7987558e580f5bbc781edff69ada795d281c33...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 10, 2021

💔 Test failed - checks-actions

nikic added 2 commits July 10, 2021 18:12
@nikic
Update binutils version
7f9467c 
This is needed to handle R_X86_64_REX_GOTPCRELX relocations.
@nikic
Use nproc instead of hardcoded 10 for build parallelism
54110fe
@nikic
Copy link
Contributor Author

nikic commented Jul 10, 2021

@bors try

Turns out we also need a slightly newer binutils to handle R_X86_64_REX_GOTPCRELX relocations. I've also taken the liberty of replacing hardcoded make -j10 with make -j$(nproc) to make this more amenable to machines with high core count, not sure if there was some reason this particular number was used.

@bors
Copy link
Collaborator

bors commented Jul 10, 2021

⌛ Trying commit 54110fe with merge 121dba2d04fc53be139c4bb9cbd678d975ba0080...

@bors
Copy link
Collaborator

bors commented Jul 10, 2021

☀️ Try build successful - checks-actions
Build commit: 121dba2d04fc53be139c4bb9cbd678d975ba0080 (121dba2d04fc53be139c4bb9cbd678d975ba0080)

@rust-timer
Copy link
Collaborator

Queued 121dba2d04fc53be139c4bb9cbd678d975ba0080 with parent 3982eb3, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (121dba2d04fc53be139c4bb9cbd678d975ba0080): comparison url.

Summary: This change led to significant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -2.1% on incr-patched: println builds of regression-31157-opt)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 10, 2021
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2021
@Mark-Simulacrum
Copy link
Member

r=me when ready

@nikic
Copy link
Contributor Author

nikic commented Jul 13, 2021

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Jul 13, 2021

📌 Commit 54110fe has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2021
@bors
Copy link
Collaborator

bors commented Jul 13, 2021

⌛ Testing commit 54110fe with merge 5aff6dd...

@bors
Copy link
Collaborator

bors commented Jul 13, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 5aff6dd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 13, 2021
@bors bors merged commit 5aff6dd into rust-lang:master Jul 13, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nikic @rust-highfive @rust-timer @bors @rust-log-analyzer @Mark-Simulacrum @rustbot