Fix type: 'satic -> 'static
#87028
Merged
Fix type: 'satic -> 'static
#87028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
And of corse I had to typo the commit message 😅 |
|
@bors r+ rollup |
|
📌 Commit 293fa8f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 10, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#87006 (Revert the revert of renaming traits::VTable to ImplSource) - rust-lang#87011 (avoid reentrant lock acquire when ThreadIds run out) - rust-lang#87013 (Fix several ICEs related to malformed `#[repr(...)]` attributes) - rust-lang#87020 (remove const_raw_ptr_to_usize_cast feature) - rust-lang#87028 (Fix type: `'satic` -> `'static`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out on discord: https://discord.com/channels/273534239310479360/490356824420122645/863434443170250793
The fact that this compiles is probably a bug.Nope it's#![feature(in_band_lifetimes)](Thanks to floppyThe docs seem to indicate rust thinks this function is generic over the lifetimeThis is because of'saticin_band_lifetimes