Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint missing Abi in ast validation instead of lowering. #87114

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Lint missing Abi in ast validation instead of lowering. #87114

merged 1 commit into from
Sep 2, 2021

Conversation

cjgillot
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2021
estebank
estebank reviewed Jul 30, 2021
View reviewed changes
compiler/rustc_ast_passes/src/ast_validation.rs
Comment on lines +883 to +905
// FIXME(davidtwco): This is a hack to detect macros which produce spans of the
// call site which do not have a macro backtrace. See #61963.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have some way to enable this to push the proc-macro ecosystem in the right direction?

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 30, 2021

📌 Commit 1f1d212 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 30, 2021
@JohnTitor
Rollup merge of rust-lang#87114 - cjgillot:abilint, r=estebank
94a9765 
Lint missing Abi in ast validation instead of lowering.
@JohnTitor JohnTitor mentioned this pull request Jul 30, 2021
Closed
@JohnTitor
Copy link
Member

Failed in rollup: #87639 (comment)
Seems we should rebase and bless tests?
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 30, 2021
@estebank
Copy link
Contributor

Ideally we could fix the code to make the pointed span not change, but either way it's fine.

@cjgillot
Copy link
Contributor Author

cjgillot commented Aug 1, 2021

Rebased.

@cjgillot cjgillot mentioned this pull request Aug 2, 2021
Merged
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2021
@inquisitivecrystal inquisitivecrystal added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2021
@bors
Copy link
Contributor

bors commented Aug 29, 2021

☔ The latest upstream changes (presumably #88208) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 30, 2021

📌 Commit f76442c460c5e29b8015deb14c7f0e9d5bd87738 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2021
bjorn3
bjorn3 reviewed Aug 31, 2021
View reviewed changes
src/test/ui/lint/cli-lint-override.forbid_warn.stderr Outdated
@@ -2,7 +2,7 @@ error: extern declarations without an explicit ABI are deprecated
--> $DIR/cli-lint-override.rs:12:1
|
LL | extern fn foo() {}
| ^^^^^^^^^^^^^^^ ABI should be specified here
| ^^^^^^^^^^^^^^^^^^ ABI should be specified here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause the entire function to be marked in ide's instead of just the function signature, which is annoying.

@cjgillot cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2021
@estebank
Copy link
Contributor

estebank commented Sep 1, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2021

📌 Commit 8d7d488 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 1, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87114 - cjgillot:abilint, r=estebank
6402071 
Lint missing Abi in ast validation instead of lowering.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 1, 2021
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 1, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87114 - cjgillot:abilint, r=estebank
7eb6f19 
Lint missing Abi in ast validation instead of lowering.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 1, 2021
Closed
@bors
Copy link
Contributor

bors commented Sep 2, 2021

⌛ Testing commit 8d7d488 with merge b27ccbc...

@bors
Copy link
Contributor

bors commented Sep 2, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing b27ccbc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2021
@bors bors merged commit b27ccbc into rust-lang:master Sep 2, 2021
@rustbot rustbot added this to the 1.56.0 milestone Sep 2, 2021
@cjgillot cjgillot deleted the abilint branch September 2, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
9 participants
@cjgillot @rust-highfive @estebank @bors @JohnTitor @bjorn3 @inquisitivecrystal @camelid @rustbot