Make SelfInTyParamDefault wording not be specific to type defaults #87134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
BoxyUwU
force-pushed
the
cgd-self-ty-error
branch
from
3f4dba3
to
da189d9
Compare
lcnr
added
A-const-generics
|
@bors r+ rollup I think differentiating between const and type parameters in this error message wouldn't be helpful as otherwise people might think that it works for the other kind when getting this error message, so using "generic" here seems like the best solution to me. |
|
📌 Commit da189d9 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r=lcnr |
|
📌 Commit b3b6b66 has been approved by |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 15, 2021
Make SelfInTyParamDefault wording not be specific to type defaults r? `@lcnr`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 15, 2021
Make SelfInTyParamDefault wording not be specific to type defaults r? ``@lcnr``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 15, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#85579 (Added Arc::try_pin) - rust-lang#86478 (Add -Zfuture-incompat-test to assist with testing future-incompat reports.) - rust-lang#86947 (Move assert_matches to an inner module) - rust-lang#87081 (Add tracking issue number to `wasi_ext`) - rust-lang#87127 (Add safety comments in private core::slice::rotate::ptr_rotate function) - rust-lang#87134 (Make SelfInTyParamDefault wording not be specific to type defaults) - rust-lang#87147 (Update cargo) - rust-lang#87154 (Fix misuse of rev attribute on <a> tag) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @lcnr