Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] Crater 2021 edition rustfix #87190

Closed
wants to merge 1 commit into from
Closed

[experiment] Crater 2021 edition rustfix #87190

wants to merge 1 commit into from

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 16, 2021 •
edited
Loading

Test

@ehuss ehuss self-assigned this Jul 16, 2021
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2021
@ehuss

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ehuss
Copy link
Contributor Author

ehuss commented Jul 16, 2021

@bors try

@bors
Copy link
Contributor

bors commented Jul 16, 2021

⌛ Trying commit 7c84275455fdea8a86f53483d51b8e00e37258b3 with merge c3c7547237edd0697fb99597a5f1735e326a9299...

@bors
Copy link
Contributor

bors commented Jul 16, 2021

☀️ Try build successful - checks-actions
Build commit: c3c7547237edd0697fb99597a5f1735e326a9299 (c3c7547237edd0697fb99597a5f1735e326a9299)

@crlf0710 crlf0710 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ehuss
Copy link
Contributor Author

ehuss commented Aug 2, 2021

@bors try

@bors
Copy link
Contributor

bors commented Aug 2, 2021

⌛ Trying commit a305973ae536916f52b1ecd2c8f09cbcbaba642d with merge 288fa8ee1ec598043ba405c5884111868698a6ca...

@bors
Copy link
Contributor

bors commented Aug 2, 2021

☀️ Try build successful - checks-actions
Build commit: 288fa8ee1ec598043ba405c5884111868698a6ca (288fa8ee1ec598043ba405c5884111868698a6ca)

@m-ou-se
Copy link
Member

m-ou-se commented Aug 2, 2021

@craterbot check crates=top-1000

@craterbot
Copy link
Collaborator

👌 Experiment pr-87190 created and queued.
🤖 Automatically detected try build 288fa8ee1ec598043ba405c5884111868698a6ca
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Aug 2, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Aug 2, 2021

@craterbot p=1

@ehuss
Copy link
Contributor Author

ehuss commented Aug 17, 2021 •
edited
Loading

failed to automatically apply fixes suggested by rustc to crate means that after applying the suggested fixes from rustc, it then runs cargo check again to validate them, and that cargo check returned an error. You can then scan the output for an "error" message.

I can't reproduce the error with abortable_parser either. I think an action item there is to enhance the error message to include the process exit code so we can see if there is an abnormal exit. I'm a bit baffled on how that could happen.

EDIT: Posted rust-lang/cargo#9799

@m-ou-se m-ou-se mentioned this pull request Aug 17, 2021
Open
@m-ou-se
Copy link
Member

m-ou-se commented Aug 17, 2021

@ehuss Can you update/rebase your cargo 2021-crater branch to include the jobserver fix?

@ehuss
Copy link
Contributor Author

ehuss commented Aug 17, 2021

@m-ou-se It should be updated now.

@bors
Copy link
Contributor

bors commented Aug 18, 2021

☔ The latest upstream changes (presumably #88127) made this pull request unmergeable. Please resolve the merge conflicts.

@m-ou-se
Copy link
Member

m-ou-se commented Aug 23, 2021

@bors try

@bors
Copy link
Contributor

bors commented Aug 23, 2021

⌛ Trying commit 9a8094e with merge a7a572ce3edd6d476191fbfe92c9c1986e009b34...

@bors
Copy link
Contributor

bors commented Aug 23, 2021

☀️ Try build successful - checks-actions
Build commit: a7a572ce3edd6d476191fbfe92c9c1986e009b34 (a7a572ce3edd6d476191fbfe92c9c1986e009b34)

@m-ou-se
Copy link
Member

m-ou-se commented Aug 23, 2021

@craterbot check p=1

@craterbot
Copy link
Collaborator

👌 Experiment pr-87190-3 created and queued.
🤖 Automatically detected try build a7a572ce3edd6d476191fbfe92c9c1986e009b34
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-87190-3 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-87190-3 is completed!
📊 1827 regressed and 14976 fixed (179415 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 25, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Aug 25, 2021 •
edited
Loading

All "regressed: root results" and "/tmp/fixit 'dependency' regressions": https://hackmd.io/xltX-gYFRpO-2OHDAW9Sag

  • 967 regressions
    • Many are categorized and analyzed by @ehuss, see the hackmd.

All other "regressed: dependencies": https://hackmd.io/go3uH7Y4T-ad6YbcNdvD8w

  • 872 regressions due to resolver = "2"
    • 701 × mime_guess missing unicase
    • 126 × diesel missing pg or sqlite
    • 14 × syn missing full, extra-traits, or visit
    • 8 × lalrpop-util missing lexer
    • 6 × serde missing derive
    • <5 × each: regex-syntax, serde_json, validators, rand_core, protobuf, simd-json
  • 1 regression due to the unused-variables lint changing an argument name used by rocket macro

@m-ou-se m-ou-se mentioned this pull request Sep 3, 2021
Closed
@JohnCSimon
Copy link
Member

@rustbot label: +S-waiting-on-author -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2021
@camelid
Copy link
Member

camelid commented Oct 8, 2021

Rust 2021 has been stabilized on beta and is likely going to be released soon, so I think this PR can be closed, right?

@apiraino apiraino added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Oct 14, 2021
@JohnCSimon
Copy link
Member

JohnCSimon commented Oct 31, 2021 •
edited
Loading

Rust 2021 has been stabilized on beta and is likely going to be released soon, so I think this PR can be closed, right?

Ping from triage:
@ehuss what is the status of this PR?

@ehuss ehuss closed this Nov 13, 2021
@m-ou-se m-ou-se removed the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
A-edition-2021 Area: The 2021 edition S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.