-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the collecting of ? Trait
bounds in where clause
#87338
Conversation
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
Thanks, LGTM! Let's do a perf run just to be sure there isn't much of an impact. @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 0f5bfc2 with merge 12fa27618837d6c2baa39ce6230ce51fab72cc8b... |
💔 Test failed - checks-actions |
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
@bors try |
⌛ Trying commit 0f5bfc2 with merge 28412d0793bff25304c9c359ae4103c872fb090b... |
☀️ Try build successful - checks-actions |
Queued 28412d0793bff25304c9c359ae4103c872fb090b with parent e742158, future comparison URL. |
Finished benchmarking try commit (28412d0793bff25304c9c359ae4103c872fb090b): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
Thanks for reviewing! I'm happy it is helpful |
@bors r+ |
📌 Commit 0f5bfc2 has been approved by |
☀️ Test successful - checks-actions |
This PR fixes the FIXME about using less rightward drift and only one error reporting when collecting of
?Trait
bounds in where clause.Checking whether the path length of
bound_ty
is 1 can be replaced by whetherunresolved_segments
in the partial_res is 0.Checking whether the
param.kind
isType{...}
can also be omitted. One Fx hash calculation will be done for Const or Lifetime param, but the impact on efficiency should be small IMO