Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #87399

Closed
wants to merge 16 commits into from
Closed

Commits on Jul 20, 2021

  1. 1 Configuration menu
    Copy the full SHA
    4853209 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Configuration menu
    Copy the full SHA
    a60f627 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef953b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0ebd6e4 View commit details
    Browse the repository at this point in the history
  4. Change rustdoc logo to use the full container size

    We have a logo in svg that scales nicely to large sizes, but by default
    is only 5px large, i.e. very small. With the change the logo expands to
    the full size. By only setting the height to 100% we ensure that the
    width-height ratio isn't changed.
    Thomasdezeeuw committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    49b1be2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    470d378 View commit details
    Browse the repository at this point in the history
  6. Don't hide fields of enum struct variants

    * The toggle adds visual clutter
    * It's easy to miss that there are fields
    * Tuple variant fields are always shown, so it is inconsistent to hide
      struct variant fields
    * It's annoying to have to click the toggle every time
    camelid committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    97623bf View commit details
    Browse the repository at this point in the history
  7. Squash all commits.

    add test for issue 86507
    
    add stderr for issue 86507
    
    update issue-86507 UI test
    
    add comment for the expected error in UI test file
    
    add proper 'refers to <ref_type>' in suggestion
    
    update diagnostic phrasing; update test to match new phrasing; re-organize logic for checking T: Sync
    
    evaluate additional obligation to figure out if T is Sync
    
    run './x.py test tidy --bless'
    
    incorporate changes from review; reorganize logic for readability
    chazkiker2 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    831ac19 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Rollup merge of rust-lang#87298 - boringcactus:patch-2, r=steveklabnik

    memorialize Anna Harren in the bastion of the turbofish
    
    this seems fitting, at least to me.
    JohnTitor authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    976d406 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#87322 - chazkiker2:fix/suggestion-ref-sync-…

    …send, r=estebank
    
    fix: clarify suggestion that `&T` must refer to `T: Sync` for `&T: Send`
    
    ### Description
    
    - [x] fix rust-lang#86507
    - [x] add UI test for relevant code from issue
    - [x] change `rustc_trait_selection/src/traits/error_reporting/suggestions.rs` to include a more clear suggestion when `&T` fails to satisfy `Send` bounds due to the fact that `T` fails to implement `Sync`
    JohnTitor authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    d089e27 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#87332 - camelid:dont-hide-fields, r=Guillau…

    …meGomez
    
    Don't hide fields of enum struct variants
    
    * The toggle adds visual clutter
    * It's easy to miss that there are fields
    * Tuple variant fields are always shown, so it is inconsistent to hide
      struct variant fields
    * It's annoying to have to click the toggle every time
    JohnTitor authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    fef2afe View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#87362 - inquisitivecrystal:bootstrap-doc, r…

    …=jyn514
    
    Make `x.py d` an alias for `x.py doc`
    
    In rust-lang/cargo#9680, `d` was added to Cargo as an alias for `doc`. This PR adds the same alias to `x.py`. The same considerations of convenience that applied to Cargo also apply to `x.py`, and in any case, the two should be kept symmetrical.
    JohnTitor authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b963b66 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#87372 - GuillaumeGomez:move-test_main-calls…

    …, r=jyn514
    
    Move calls to test_main into one function
    
    Fixes rust-lang#86254.
    
    cc `@jyn514`
    r? `@camelid`
    JohnTitor authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    ffd0a3c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#87373 - Aaron1011:hir-wf-field, r=estebank

    Extend HIR WF checking to fields
    
    r? `@estebank`
    JohnTitor authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    23cedd7 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#87376 - Thomasdezeeuw:rustdoc-large-logo, r…

    …=GuillaumeGomez
    
    Change rustdoc logo to use the full container size
    
    We have a logo in svg that scales nicely to large sizes, but by default
    is only 5px large, i.e. very small. With the change the logo expands to
    the full size. By only setting the height to 100% we ensure that the
    width-height ratio isn't changed.
    JohnTitor authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b1fa06b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#87383 - Alexendoo:impl_trait_in_bindings-te…

    …sts, r=oli-obk
    
    Add regression tests for the impl_trait_in_bindings ICEs
    
    Closes rust-lang#54600, closes rust-lang#54840, closes rust-lang#58504, closes rust-lang#58956, closes rust-lang#70971, closes rust-lang#79099, closes rust-lang#84919, closes rust-lang#86201, closes rust-lang#86642, closes rust-lang#87295
    
    r? `@oli-obk`
    JohnTitor authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    15b2d95 View commit details
    Browse the repository at this point in the history