Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf test #87280 #87407

Closed
wants to merge 16 commits into from
Closed

perf test #87280 #87407

wants to merge 16 commits into from

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 23, 2021

slightly modified to figure out where the regression is coming from

cc #87280
r? @ghost

@lcnr
Copy link
Contributor Author

lcnr commented Jul 23, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 23, 2021
@bors
Copy link
Contributor

bors commented Jul 23, 2021

⌛ Trying commit 08b62679f832a8b458ecede284807ba4994c9e32 with merge d14be679290d89abfb8d698975d47a816e3a30b4...

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jul 23, 2021

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 23, 2021
@bors
Copy link
Contributor

bors commented Jul 24, 2021

☔ The latest upstream changes (presumably #86461) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr
Copy link
Contributor Author

lcnr commented Jul 25, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jul 25, 2021

⌛ Trying commit 41d1486e11d7d1c2dea2179e449bb7e8e44d7a75 with merge 906e14b8a1c37638d5227149717e52bba78c9bd5...

@bors
Copy link
Contributor

bors commented Jul 25, 2021

☀️ Try build successful - checks-actions
Build commit: 906e14b8a1c37638d5227149717e52bba78c9bd5 (906e14b8a1c37638d5227149717e52bba78c9bd5)

@rust-timer
Copy link
Collaborator

Queued 906e14b8a1c37638d5227149717e52bba78c9bd5 with parent 70f7471, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (906e14b8a1c37638d5227149717e52bba78c9bd5): comparison url.

Summary: This change led to significant regressions 😿 in compiler performance.

  • Very large regression in instruction counts (up to 14.5% on full builds of ctfe-stress-4-check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 25, 2021
@lcnr
Copy link
Contributor Author

lcnr commented Aug 2, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 2, 2021
@bors
Copy link
Contributor

bors commented Aug 2, 2021

⌛ Trying commit ac752bfab3d933a774f4d0d49ef1204bfb0123b8 with merge a04ea67a5182d089f522d6fdc21c69404b3447c4...

@bors
Copy link
Contributor

bors commented Aug 2, 2021

☀️ Try build successful - checks-actions
Build commit: a04ea67a5182d089f522d6fdc21c69404b3447c4 (a04ea67a5182d089f522d6fdc21c69404b3447c4)

@rust-timer
Copy link
Collaborator

Queued a04ea67a5182d089f522d6fdc21c69404b3447c4 with parent effea9a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (a04ea67a5182d089f522d6fdc21c69404b3447c4): comparison url.

Summary: This change led to significant regressions 😿 in compiler performance.

  • Very large regression in instruction counts (up to 15.5% on full builds of ctfe-stress-4-check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2021
@lcnr
Copy link
Contributor Author

lcnr commented Aug 17, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 17, 2021
@bors
Copy link
Contributor

bors commented Aug 17, 2021

⌛ Trying commit 6515738 with merge 22a1bd761de8b0ac85d9ecaae5f262d5798a4409...

@bors
Copy link
Contributor

bors commented Aug 17, 2021

☀️ Try build successful - checks-actions
Build commit: 22a1bd761de8b0ac85d9ecaae5f262d5798a4409 (22a1bd761de8b0ac85d9ecaae5f262d5798a4409)

@rust-timer
Copy link
Collaborator

Queued 22a1bd761de8b0ac85d9ecaae5f262d5798a4409 with parent 3b5df01, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (22a1bd761de8b0ac85d9ecaae5f262d5798a4409): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 3.5% on full builds of ctfe-stress-4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 17, 2021
@inquisitivecrystal inquisitivecrystal added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2021
@lcnr lcnr closed this Aug 27, 2021
@lcnr lcnr deleted the perf-test branch August 27, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants