Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track caller of Vec::remove() #87488

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Track caller of Vec::remove() #87488

merged 1 commit into from
Jul 31, 2021

Conversation

kornelski
Copy link
Contributor

vec.remove(invalid) doesn't print a helpful source position:

thread 'main' panicked at 'removal index (is 99) should be < len (is 1)', library/alloc/src/vec/mod.rs:1379:13

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2021
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dtolnay
Copy link
Member

dtolnay commented Jul 26, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jul 26, 2021

📌 Commit 624df18 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 27, 2021
Track caller of Vec::remove()

`vec.remove(invalid)` doesn't print a helpful source position:

> thread 'main' panicked at 'removal index (is 99) should be < len (is 1)', **library/alloc/src/vec/mod.rs:1379:13**
@Aaron1011
Copy link
Member

@bors try @rust-timer queue

@bors
Copy link
Contributor

bors commented Jul 27, 2021

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 27, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 29, 2021
Track caller of Vec::remove()

`vec.remove(invalid)` doesn't print a helpful source position:

> thread 'main' panicked at 'removal index (is 99) should be < len (is 1)', **library/alloc/src/vec/mod.rs:1379:13**
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jul 29, 2021
Track caller of Vec::remove()

`vec.remove(invalid)` doesn't print a helpful source position:

> thread 'main' panicked at 'removal index (is 99) should be < len (is 1)', **library/alloc/src/vec/mod.rs:1379:13**
@bors
Copy link
Contributor

bors commented Jul 31, 2021

⌛ Testing commit 624df18 with merge b289bb7...

@bors
Copy link
Contributor

bors commented Jul 31, 2021

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing b289bb7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2021
@bors bors merged commit b289bb7 into rust-lang:master Jul 31, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 31, 2021
@kornelski kornelski deleted the track-remove branch July 31, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants