Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RELEASES.md for 1.55.0 #87624

Closed
wants to merge 0 commits into from
Closed

Conversation

XAMPPRocky
Copy link
Member

Rendered

r? @Mark-Simulacrum
cc @rust-lang/release

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2021
@XAMPPRocky XAMPPRocky added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jul 30, 2021
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I'm sorry, the rustdoc team has not been great about tagging PRs with relnotes as the land. I added a few just now - do you mind adding them to the release notes? https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Amerged+label%3AT-rustdoc+label%3Arelnotes+milestone%3A1.55.0

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
@inquisitivecrystal
Copy link
Contributor

I'm not an expert, but it looks great to me!

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated

Language
--------
- [You can create bindings inside of a `@` bindings pattern.][85305] E.g. the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This landed into 1.56, per the milestone on the stabilization PR.

@Mark-Simulacrum
Copy link
Member

Hm, that seems to have not worked, weird, not sure what went wrong there. I'll open a new PR and r+ it in short order.

camsteffen added a commit to camsteffen/rust that referenced this pull request Aug 15, 2021
…rk-Simulacrum

Update RELEASES.md for 1.55.0

Reopening rust-lang#87624 after some edits and a force-push caused GitHub to close the PR.
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Aug 16, 2021
…rk-Simulacrum

Update RELEASES.md for 1.55.0

Reopening rust-lang#87624 after some edits and a force-push caused GitHub to close the PR.
@Aaron1011
Copy link
Member

@Mark-Simulacrum For future reference, https://gist.github.com/robertpainsi/2c42c15f1ce6dab03a0675348edd4e2c described how to reopen a PR after force pushing to it.

@XAMPPRocky
Copy link
Member Author

XAMPPRocky commented Aug 16, 2021

@Aaron1011 That might be useful to link in forge somewhere, it seems to come up enough.

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Aug 16, 2021
…rk-Simulacrum

Update RELEASES.md for 1.55.0

Reopening rust-lang#87624 after some edits and a force-push caused GitHub to close the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants