-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intra doc link in hidden doc of Iterator::__iterator_get_unchecked #87842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Aug 7, 2021
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 7, 2021
dtolnay
approved these changes
Aug 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ rollup |
📌 Commit 5c30df5 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 7, 2021
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 7, 2021
…=dtolnay Fix intra doc link in hidden doc of Iterator::__iterator_get_unchecked Recently, I edited the import list of the `core::iter::traits::iterator` module (in rust-lang#85874). This results in a broken intra doc link in a hidden documentation with the effect that `RUSTDOCFLAGS='--document-private-items --document-hidden-items' x doc library/std` fails. (This can be worked around by adding `-Arustdoc::broken-intra-doc-links`; still, it’s a broken link so let’s fix it.) `@rustbot` label C-cleanup, T-libs
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#87744 (Add x.py option to --force-rerun compiletest tests) - rust-lang#87789 (Make vec-shrink-panic test compatible with v0 mangling) - rust-lang#87833 (Fix typo -- "The" -> "They") - rust-lang#87834 (Fix small typo) - rust-lang#87838 (Document that fs::read_dir skips . and ..) - rust-lang#87842 (Fix intra doc link in hidden doc of Iterator::__iterator_get_unchecked) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I edited the import list of the
core::iter::traits::iterator
module (in #85874). This results in a broken intra doc link in a hidden documentation with the effect thatRUSTDOCFLAGS='--document-private-items --document-hidden-items' x doc library/std
fails. (This can be worked around by adding-Arustdoc::broken-intra-doc-links
; still, it’s a broken link so let’s fix it.)@rustbot label C-cleanup, T-libs