Naming & minor type adjustments to std::unstable::sync::UnsafeAtomicRcBox #8790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that fewer `transmute`s are required, so there is less chance of a `transmute` not having the corresponding `forget` (possibly leading to use-after-free, etc).
bors
added a commit
that referenced
this pull request
Aug 27, 2013
`UnsafeAtomicRcBox` → `UnsafeArc` (#7674), and `AtomicRcBoxData` → `ArcData` to reflect this. Also, the inner pointer of `UnsafeArc` is now `*mut ArcData`, which avoids some transmutes to `~`: i.e. less chance of mistakes.
xFrednet
pushed a commit
to xFrednet/rust
that referenced
this pull request
May 21, 2022
Lint `empty_lint_after_outer_attr` on argumentless macros Reverts the change from 034c81b as it's no longer needed. The test is left just in case. Original issue is rust-lang#2475. changelog: Lint `empty_lint_after_outer_attr` on argumentless macros again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnsafeAtomicRcBox→UnsafeArc(#7674), andAtomicRcBoxData→ArcDatato reflect this.Also, the inner pointer of
UnsafeArcis now*mut ArcData, which avoids some transmutes to~: i.e. less chance of mistakes.