-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable unit tests in libstd and libextra on Windows #8819
Conversation
Does it make sense to change |
My understanding is that |
@sanxiyn From my perspective 'check-fast' is just the target we use on the windows bots, so if there are tests we want to run there then it's fine to include them. |
@brson Shouldn't we rename the target to |
Assuming this lands, it sounds like it will fix #5261 (at least partially, maybe not enough to close the ticket...) I don't know if I would want to rename |
Also, regarding renaming |
Some of the tests are failing. I've only managed to fix 'memory_map_file', the rest are up for grabs... Fixes #5261.
Hmm, I don't think I've changed any non-windows code. Is there a way to get a callstack or something? |
Some of the tests are failing. I've only managed to fix 'memory_map_file', the rest are up for grabs... Fixes #5261.
Some of the tests are failing. I've only managed to fix 'memory_map_file', the rest are up for grabs...
Fixes #5261.