Remove bolding on associated constants #88410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-associated-items
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
FYI, this is the PR that introduced the |
|
The 'Associated Constants' section is unchanged. What changed is the pretty-printed item declaration (that should be the only change). Before
After
|
|
Please add tests in |
camelid
added
S-waiting-on-author
camelid
force-pushed
the
fix-assoc-bold
branch
from
51413f1 to
ff82a2b
Compare
@GuillaumeGomez I added a GUI test case to check the font-weight since that will also catch if the font-weight changes because of CSS. |
camelid
added
S-waiting-on-review
camelid
force-pushed
the
fix-assoc-bold
branch
from
ff82a2b to
e9ece9d
Compare
This comment has been minimized.
This comment has been minimized.
camelid
force-pushed
the
fix-assoc-bold
branch
from
e9ece9d to
66038d2
Compare
camelid
force-pushed
the
fix-assoc-bold
branch
from
66038d2 to
c265d46
Compare
Associated types don't get bolded, so it looks off to have one kind bolded and one not.
camelid
force-pushed
the
fix-assoc-bold
branch
from
c265d46 to
87e39ac
Compare
|
@bors r=GuillaumeGomez |
|
📌 Commit 87e39ac has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 1, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#86376 (Emit specific warning to clarify that `#[no_mangle]` should not be applied on foreign statics or functions) - rust-lang#88040 (BTree: remove Ord bound from new) - rust-lang#88053 (Fix the flock fallback implementation) - rust-lang#88350 (add support for clobbering xer, cr, and cr[0-7] for asm! on OpenPower/PowerPC) - rust-lang#88410 (Remove bolding on associated constants) - rust-lang#88525 (fix(rustc_typeck): produce better errors for dyn auto trait) - rust-lang#88542 (Use the return value of readdir_r() instead of errno) - rust-lang#88548 (Stabilize `Iterator::intersperse()`) - rust-lang#88551 (Stabilize `UnsafeCell::raw_get()`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated types don't get bolded, so it looks off to have one kind
bolded and one not.