sunos systems add sanitizer supported.

[devnexen]

No description provided.

[rust-highfive]

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

⚠️ Warning ⚠️

• These commits modify compiler targets. (See the Target Tier Policy.)

[wesleywiser]

Does bootstrap/native.rs also need to be updated?

rust/src/bootstrap/native.rs

Lines 801 to 850 in 6cfa773

	/// Returns sanitizers available on a given target.
	fn supported_sanitizers(
	out_dir: &Path,
	target: TargetSelection,
	channel: &str,
	) -> Vec<SanitizerRuntime> {
	let darwin_libs = |os: &str, components: &[&str]| -> Vec<SanitizerRuntime> {
	components
	.iter()
	.map(move |c| SanitizerRuntime {
	cmake_target: format!("clang_rt.{}_{}_dynamic", c, os),
	path: out_dir
	.join(&format!("build/lib/darwin/libclang_rt.{}_{}_dynamic.dylib", c, os)),
	name: format!("librustc-{}_rt.{}.dylib", channel, c),
	})
	.collect()
	};
	let common_libs = |os: &str, arch: &str, components: &[&str]| -> Vec<SanitizerRuntime> {
	components
	.iter()
	.map(move |c| SanitizerRuntime {
	cmake_target: format!("clang_rt.{}-{}", c, arch),
	path: out_dir.join(&format!("build/lib/{}/libclang_rt.{}-{}.a", os, c, arch)),
	name: format!("librustc-{}_rt.{}.a", channel, c),
	})
	.collect()
	};
	match &*target.triple {
	"aarch64-apple-darwin" => darwin_libs("osx", &["asan", "lsan", "tsan"]),
	"aarch64-fuchsia" => common_libs("fuchsia", "aarch64", &["asan"]),
	"aarch64-unknown-linux-gnu" => {
	common_libs("linux", "aarch64", &["asan", "lsan", "msan", "tsan", "hwasan"])
	}
	"x86_64-apple-darwin" => darwin_libs("osx", &["asan", "lsan", "tsan"]),
	"x86_64-fuchsia" => common_libs("fuchsia", "x86_64", &["asan"]),
	"x86_64-unknown-freebsd" => common_libs("freebsd", "x86_64", &["asan", "msan", "tsan"]),
	"x86_64-unknown-netbsd" => {
	common_libs("netbsd", "x86_64", &["asan", "lsan", "msan", "tsan"])
	}
	"x86_64-unknown-linux-gnu" => {
	common_libs("linux", "x86_64", &["asan", "lsan", "msan", "tsan"])
	}
	"x86_64-unknown-linux-musl" => {
	common_libs("linux", "x86_64", &["asan", "lsan", "msan", "tsan"])
	}
	_ => Vec::new(),
	}
	}

Or are these only supported at a codegen level currently?

rust/compiler/rustc_target/src/spec/mod.rs

Lines 1330 to 1335 in 6cfa773

	/// The sanitizers supported by this target
	///
	/// Note that the support here is at a codegen level. If the machine code with sanitizer
	/// enabled can generated on this target, but the necessary supporting libraries are not
	/// distributed with the target, the sanitizer should still appear in this list for the target.
	pub supported_sanitizers: SanitizerSet,

[devnexen]

nah I just forgot to update these thx :-)

[wesleywiser]

Looks great, thanks!

[wesleywiser]

@bors r+

[bors]

📌 Commit 8539a3c has been approved by wesleywiser

[bors]

⌛ Testing commit 8539a3c with merge 4878034...

[bors]

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 4878034 to master...