fix non_blanket_impls iteration order #88718
Conversation
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 5ebbb28 with merge 9aa59c4f07da2a73629023de08a2231a65e25965... |
|
☀️ Try build successful - checks-actions |
|
Queued 9aa59c4f07da2a73629023de08a2231a65e25965 with parent 385f8e2, future comparison URL. |
|
Finished benchmarking commit (9aa59c4f07da2a73629023de08a2231a65e25965): comparison url. Summary: This change led to large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
rustbot
added
perf-regression
|
that doesn't seem like an acceptable regression here, will have to do this differently |
|
OK. Closing this PR, then. |
…s,michaelwoerister fix non_blanket_impls iteration order We sometimes iterate over all `non_blanket_impls`, not sure if this is observable outside of error messages (i.e. as incremental bugs). This should fix the underlying issue of rust-lang#86986. second attempt of rust-lang#88718 r? `@nikomatsakis`
We sometimes iterate over all non_blanket_impls, not sure if this is observable outside
of error messages (i.e. as incremental bugs), but it hopefully fixes the underlying issue of #86986.
It does not fix the issue of #86986, as the iteration order still isn't stable between different targets
r? @nikomatsakis @Aaron1011