Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a HashMap for UniverseInfo in mir borrowck #88811

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

jackh726
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2021
@jackh726
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 10, 2021
@bors
Copy link
Contributor

bors commented Sep 10, 2021

⌛ Trying commit 47035e4 with merge c85285459be3d592ede0cbcf9437bf96581ce47e...

@bors
Copy link
Contributor

bors commented Sep 10, 2021

☀️ Try build successful - checks-actions
Build commit: c85285459be3d592ede0cbcf9437bf96581ce47e (c85285459be3d592ede0cbcf9437bf96581ce47e)

@rust-timer
Copy link
Collaborator

Queued c85285459be3d592ede0cbcf9437bf96581ce47e with parent 497ee32, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c85285459be3d592ede0cbcf9437bf96581ce47e): comparison url.

Summary: This change led to small relevant regressions 😿 in compiler performance.

  • Small regression in instruction counts (up to 0.4% on incr-full builds of html5ever)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 10, 2021
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 10, 2021

📌 Commit 47035e4 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Sep 10, 2021

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2021
@bors
Copy link
Contributor

bors commented Sep 12, 2021

⌛ Testing commit 47035e4 with merge d2dfb0e...

@bors
Copy link
Contributor

bors commented Sep 12, 2021

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing d2dfb0e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2021
@bors bors merged commit d2dfb0e into rust-lang:master Sep 12, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 12, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d2dfb0e): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@rustbot rustbot removed the perf-regression Performance regression. label Sep 12, 2021
@jackh726 jackh726 deleted the issue-88446 branch September 12, 2021 22:27
@jackh726 jackh726 restored the issue-88446 branch March 12, 2022 18:30
@jackh726 jackh726 deleted the issue-88446 branch March 12, 2022 18:35
@jackh726 jackh726 restored the issue-88446 branch March 12, 2022 18:42
@jackh726 jackh726 deleted the issue-88446 branch March 12, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertion failed: (left == right) in relate_tys.rs
6 participants