Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode span parent in the inlined representation. #88886

Closed
wants to merge 1 commit into from
Closed

Encode span parent in the inlined representation. #88886

wants to merge 1 commit into from

Conversation

cjgillot
Copy link
Contributor

Follow-up to #84373 attempting to store SpanData::parent in the inline Span implementation.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2021
@michaelwoerister
Copy link
Member

r? @JohnTitor (randomly picked someone from wg-diagnostics, feel free to re-assign)

@michaelwoerister
Copy link
Member

Sorry, wrong PR :)

r? @michaelwoerister

@michaelwoerister
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 14, 2021
@bors
Copy link
Contributor

bors commented Sep 14, 2021

⌛ Trying commit fb97675ade329b7a5b6d4802f8e4a16f255ff286 with merge a13e5e0fd686d901e52bfc27198f084a6e09f3d7...

@bors
Copy link
Contributor

bors commented Sep 14, 2021

☀️ Try build successful - checks-actions
Build commit: a13e5e0fd686d901e52bfc27198f084a6e09f3d7 (a13e5e0fd686d901e52bfc27198f084a6e09f3d7)

@rust-timer
Copy link
Collaborator

Queued a13e5e0fd686d901e52bfc27198f084a6e09f3d7 with parent ec9a1bd, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a13e5e0fd686d901e52bfc27198f084a6e09f3d7): comparison url.

Summary: This change led to small relevant regressions 😿 in compiler performance.

  • Small regression in instruction counts (up to 0.6% on incr-unchanged builds of tuple-stress)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 14, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 14, 2021
@michaelwoerister
Copy link
Member

Is this PR still active? It does not seem to give the performance improvements we hoped for.

@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2021
@cjgillot cjgillot force-pushed the resolve-span-inlined branch 2 times, most recently from ac6d61d to 57560c8 Compare October 23, 2021 19:59
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2021
@JohnCSimon JohnCSimon removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 5, 2021
@JohnCSimon JohnCSimon added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 5, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2022
@JohnCSimon
Copy link
Member

@cjgillot - ping from triage:

Is this PR still active? It does not seem to give the performance improvements we hoped for.

@cjgillot cjgillot closed this Apr 23, 2022
@cjgillot cjgillot deleted the resolve-span-inlined branch April 23, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjgillot @rust-highfive @michaelwoerister @rust-timer @bors @JohnCSimon @apiraino @JohnTitor @jackh726 @rustbot