-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode span parent in the inlined representation. #88886
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
r? @JohnTitor (randomly picked someone from wg-diagnostics, feel free to re-assign) |
Sorry, wrong PR |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit fb97675ade329b7a5b6d4802f8e4a16f255ff286 with merge a13e5e0fd686d901e52bfc27198f084a6e09f3d7... |
☀️ Try build successful - checks-actions |
Queued a13e5e0fd686d901e52bfc27198f084a6e09f3d7 with parent ec9a1bd, future comparison URL. |
Finished benchmarking commit (a13e5e0fd686d901e52bfc27198f084a6e09f3d7): comparison url. Summary: This change led to small relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Is this PR still active? It does not seem to give the performance improvements we hoped for. |
ac6d61d
to
57560c8
Compare
57560c8
to
47245d9
Compare
47245d9
to
86253b9
Compare
86253b9
to
24092bf
Compare
@cjgillot - ping from triage:
|
Follow-up to #84373 attempting to store
SpanData::parent
in the inlineSpan
implementation.