Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline(always) on check_recursion_limit #88962

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

fee1-dead
Copy link
Member

r? @oli-obk

#88558 caused a regression, this PR adds #[inline(always)] to check_recursion_limit, a possible suspect of that regression.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2021
@fee1-dead fee1-dead mentioned this pull request Sep 15, 2021
3 tasks
@oli-obk
Copy link
Contributor

oli-obk commented Sep 15, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 15, 2021
@bors
Copy link
Contributor

bors commented Sep 15, 2021

⌛ Trying commit b76b2c2 with merge 3d66748e5a10de468e3530099450e33554ed5bb8...

@bors
Copy link
Contributor

bors commented Sep 15, 2021

☀️ Try build successful - checks-actions
Build commit: 3d66748e5a10de468e3530099450e33554ed5bb8 (3d66748e5a10de468e3530099450e33554ed5bb8)

@rust-timer
Copy link
Collaborator

Queued 3d66748e5a10de468e3530099450e33554ed5bb8 with parent cdeba02, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3d66748e5a10de468e3530099450e33554ed5bb8): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 15, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Sep 15, 2021

it does get us some of the perf back (these were all small regressions in #88558)

so let's keep looking, but also

@bors r+

@bors
Copy link
Contributor

bors commented Sep 15, 2021

📌 Commit b76b2c2 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@bors
Copy link
Contributor

bors commented Sep 17, 2021

⌛ Testing commit b76b2c2 with merge a58db2e...

@bors
Copy link
Contributor

bors commented Sep 18, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing a58db2e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2021
@bors bors merged commit a58db2e into rust-lang:master Sep 18, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 18, 2021
@fee1-dead fee1-dead deleted the const-drop branch May 21, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants