Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the std_detect env_override feature #88973

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Sep 15, 2021

No description provided.

@lu-zero
Copy link
Contributor Author

lu-zero commented Sep 24, 2021

r? @bjorn3

@bjorn3
Copy link
Member

bjorn3 commented Sep 25, 2021

r? @Amanieu Whether or not to expose this feature is not a decision I think I should make.

@rust-highfive rust-highfive assigned Amanieu and unassigned bjorn3 Sep 25, 2021
@Amanieu
Copy link
Member

Amanieu commented Sep 25, 2021

You need to add it to the test crate as well for -Z build-std-features to work.

Also keep in mind that features on standard library crates are considered unstable and may change until -Z build-std-features is stabilized.

@lu-zero lu-zero force-pushed the std_detect-env_override branch from f23f59a to 160b939 Compare September 25, 2021 18:30
@lu-zero
Copy link
Contributor Author

lu-zero commented Sep 25, 2021

Thank you for spotting it! It is good to consider it unstable.

@Amanieu
Copy link
Member

Amanieu commented Sep 26, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 26, 2021

📌 Commit 160b939 has been approved by Amanieu

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 26, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2021
…arth

Rollup of 7 pull requests

Successful merges:

 - rust-lang#88895 (rustdoc: Cleanup `clean` part 2)
 - rust-lang#88973 (Expose the std_detect env_override feature)
 - rust-lang#89010 (Add some intra doc links)
 - rust-lang#89198 (rustdoc: Don't show hidden trait methods)
 - rust-lang#89216 (Consistent big O notation)
 - rust-lang#89224 (Change the order of imports suggestions)
 - rust-lang#89256 (Fix typo in release notes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f9d4eb0 into rust-lang:master Sep 26, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants