-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
outline heavyweight closure that caused regressions in #86898 #89026
outline heavyweight closure that caused regressions in #86898 #89026
Conversation
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit d878815 with merge ae450c524eac0a8a0226f49bf374b24f9406824f... |
☀️ Try build successful - checks-actions |
Queued ae450c524eac0a8a0226f49bf374b24f9406824f with parent 237bb5e, future comparison URL. |
Finished benchmarking commit (ae450c524eac0a8a0226f49bf374b24f9406824f): comparison url. Summary: This change led to small relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
The nesting is getting quite nasty there, but also waaaaat o.O @bors r+ |
📌 Commit d878815 has been approved by |
…e, r=Mark-Simulacrum Don't inline OnceCell initialization closures The more general variant of rust-lang#89026, originally suggested in rust-lang#86898 (comment)
Testing the suggestion in #86898 (comment)