Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outline heavyweight closure that caused regressions in #86898 #89026

Conversation

the8472
Copy link
Member

@the8472 the8472 commented Sep 16, 2021

Testing the suggestion in #86898 (comment)

@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2021
@the8472
Copy link
Member Author

the8472 commented Sep 16, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 16, 2021
@bors
Copy link
Contributor

bors commented Sep 16, 2021

⌛ Trying commit d878815 with merge ae450c524eac0a8a0226f49bf374b24f9406824f...

@bors
Copy link
Contributor

bors commented Sep 16, 2021

☀️ Try build successful - checks-actions
Build commit: ae450c524eac0a8a0226f49bf374b24f9406824f (ae450c524eac0a8a0226f49bf374b24f9406824f)

@rust-timer
Copy link
Collaborator

Queued ae450c524eac0a8a0226f49bf374b24f9406824f with parent 237bb5e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ae450c524eac0a8a0226f49bf374b24f9406824f): comparison url.

Summary: This change led to small relevant improvements 🎉 in compiler performance.

  • Small improvement in instruction counts (up to -0.6% on full builds of issue-46449)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 17, 2021
@nagisa
Copy link
Member

nagisa commented Sep 17, 2021

The nesting is getting quite nasty there, but also waaaaat o.O

@bors r+

@bors
Copy link
Contributor

bors commented Sep 17, 2021

📌 Commit d878815 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2021
@the8472
Copy link
Member Author

the8472 commented Sep 17, 2021

@bors r-

#89031 shows similar results, is more general and has been approved too.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2021
@the8472 the8472 closed this Sep 17, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2021
…e, r=Mark-Simulacrum

Don't inline OnceCell initialization closures

The more general variant of rust-lang#89026, originally suggested in rust-lang#86898 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants