Simplify explicit request check and allow to run "doc src/librustdoc" even without config set #89182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
added
the
T-infra
GuillaumeGomez
force-pushed
the
boostrap-explicit-request
branch
from
35a30fc to
2091759
Compare
|
Updated! |
|
r=me with last nit fixed (or telling me I got the comment wrong) and squashed in |
GuillaumeGomez
force-pushed
the
boostrap-explicit-request
branch
from
2091759 to
10bef56
Compare
|
@bors: r=Mark-Simulacrum |
|
📌 Commit 10bef56 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (04006d8): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I wanted to allow the command
doc src/librustdocto work when passed explicitly but then @Mark-Simulacrum recommended me to generalize it, so here we are!r? @Mark-Simulacrum