Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move encode_metadata out of CrateStore. #89183

Merged
merged 5 commits into from
Oct 1, 2021
Merged

Move encode_metadata out of CrateStore. #89183

merged 5 commits into from
Oct 1, 2021

Conversation

cjgillot
Copy link
Contributor

rustc_metadata is already accessible by all client crates. It does not need to be called trough a trait object.

@rust-highfive
Copy link
Collaborator

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2021
@bjorn3
Copy link
Member

bjorn3 commented Sep 22, 2021

Can you move EncodedMetadata to rustc_metadata?

@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

Calls through a trait object might be saving us some codegen time and such (if things are not getting inlined, etc.). Seems unlikely, but worth checking, I think.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 22, 2021
@bors
Copy link
Contributor

bors commented Sep 22, 2021

⌛ Trying commit 53cd5168934f0567537415e54fe9d36aa86089bd with merge bb92ee19d26561c6b263a4c79e77c0b2dc084980...

@bors
Copy link
Contributor

bors commented Sep 23, 2021

☀️ Try build successful - checks-actions
Build commit: bb92ee19d26561c6b263a4c79e77c0b2dc084980 (bb92ee19d26561c6b263a4c79e77c0b2dc084980)

@rust-timer
Copy link
Collaborator

Queued bb92ee19d26561c6b263a4c79e77c0b2dc084980 with parent 308dffd, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bb92ee19d26561c6b263a4c79e77c0b2dc084980): comparison url.

Summary: This change led to small relevant regressions 😿 in compiler performance.

  • Small regression in instruction counts (up to 0.5% on incr-unchanged builds of helloworld)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 23, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot cjgillot mentioned this pull request Sep 26, 2021
Merged
@bors
Copy link
Contributor

bors commented Sep 27, 2021

☔ The latest upstream changes (presumably #89092) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 28, 2021

the change lgtm, but considering it's just a redesign, but regresses perf, should we really do this? Do you need this for some other PRs?

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 28, 2021
@bors
Copy link
Contributor

bors commented Sep 28, 2021

⌛ Trying commit c013cd38c94f26e9fd03b73db411530d87ad2dff with merge afea9a948dbff21b30109ada462b7bda076ac676...

@bors
Copy link
Contributor

bors commented Sep 28, 2021

☀️ Try build successful - checks-actions
Build commit: afea9a948dbff21b30109ada462b7bda076ac676 (afea9a948dbff21b30109ada462b7bda076ac676)

@rust-timer
Copy link
Collaborator

Queued afea9a948dbff21b30109ada462b7bda076ac676 with parent 8f8092c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (afea9a948dbff21b30109ada462b7bda076ac676): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Sep 29, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Sep 30, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2021

📌 Commit 2d51b78 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2021
@bors
Copy link
Contributor

bors commented Oct 1, 2021

⌛ Testing commit 2d51b78 with merge 1c0ed0d...

@bors
Copy link
Contributor

bors commented Oct 1, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 1c0ed0d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 1, 2021
@bors bors merged commit 1c0ed0d into rust-lang:master Oct 1, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 1, 2021
This was referenced Oct 1, 2021
Merged
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1c0ed0d): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@cjgillot cjgillot deleted the noenc branch October 1, 2021 18:03
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 5, 2021
@bors
Auto merge of rust-lang#89266 - cjgillot:session-ich, r=michaelwoerister
55111d6 
Move ICH to rustc_query_system

Based on rust-lang#89183

The StableHashingContext does not need to be in rustc_middle.

This PR moves it to rustc_query_system. This will avoid a dependency between rustc_ast_lowering and rustc_middle in rust-lang#89124.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
9 participants
@cjgillot @rust-highfive @bjorn3 @Mark-Simulacrum @rust-timer @bors @rust-log-analyzer @oli-obk @rustbot