Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve help for recursion limit errors #89232

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Improve help for recursion limit errors #89232

merged 1 commit into from
Sep 30, 2021

Conversation

rossmacarthur
Copy link
Contributor

Fixes #76424

@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rossmacarthur rossmacarthur force-pushed the fix-76424 branch 2 times, most recently from bbb873e to cedfa18 Compare September 25, 2021 05:49
@wesleywiser
Copy link
Member

Thank you!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 27, 2021

📌 Commit cedfa18 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 28, 2021
Closed
@GuillaumeGomez
Copy link
Member

It failed in #89330.

@bors: r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2021
@rossmacarthur
Copy link
Contributor Author

Woops, not sure how that snuck in. All fixed.

r? @wesleywiser

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r=wesleywiser

@bors
Copy link
Contributor

bors commented Sep 28, 2021

📌 Commit d2613fb has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 29, 2021
Closed
@ehuss ehuss mentioned this pull request Sep 30, 2021
Merged
@bors bors merged commit 8087147 into rust-lang:master Sep 30, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 30, 2021
@rossmacarthur rossmacarthur deleted the fix-76424 branch September 30, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.

ICE with recursion_limit = 0
7 participants
@rossmacarthur @rust-highfive @rust-log-analyzer @wesleywiser @bors @GuillaumeGomez @rustbot