Hide ToString
specializations behind a private trait
#89253
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we use private traits for specializing
impl
s butToString
's were public and the original PR #32586 doesn't seem to have a reason for this. This PR moves those impls to a hidden perma-unstableSpecToString
trait (I would have made it private ifproc_macro
didn't have to specialize it too) and delegates to it, leaving only theimpl<T: fmt::Display + ?Sized> ToStringSpec for T
as public.