Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest using the path separator for tuple struct #89293

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Sep 27, 2021

Fix confusing error message constructor is not visible here due to private fields for tuple struct

closes #83450

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2021
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 27, 2021

📌 Commit 564cb87 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2021
@bors
Copy link
Collaborator

bors commented Sep 28, 2021

⌛ Testing commit 564cb87 with merge 83f147b...

@bors
Copy link
Collaborator

bors commented Sep 28, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 83f147b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2021
@bors bors merged commit 83f147b into rust-lang:master Sep 28, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 28, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (83f147b): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@TaKO8Ki TaKO8Ki deleted the fix-confusing-error-for-path-separator-to-refer-to-an-struct-item branch September 28, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confusing error message 'constructor is not visible here due to private fields'
6 participants