Make std::thread::available_concurrency support process-limited number of CPUs
#89310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
joshtriplett
changed the title
std::thread::available_concurrency support process-limited number of CPUs
7 tasks
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
available-concurrency-affinity
branch
from
d6affdc
to
33e4614
Compare
joshtriplett
added
the
T-libs-api
yoshuawuyts
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Compared this against num_cpus/linux.rs, and this looks good!
yoshuawuyts
reviewed
Sep 28, 2021
m-ou-se
reviewed
Oct 3, 2021
joshtriplett
force-pushed
the
available-concurrency-affinity
branch
from
33e4614
to
433439e
Compare
|
I believe this PR should be ready to be merged? |
|
@bors r+ |
|
📌 Commit 433439e has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2021
…affinity, r=m-ou-se Make `std::thread::available_concurrency` support process-limited number of CPUs Use `libc::sched_getaffinity` and count the number of CPUs in the returned mask. This handles cases where the process doesn't have access to all CPUs, such as when limited via `taskset` or similar. This also covers cgroup cpusets.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2021
…affinity, r=m-ou-se Make `std::thread::available_concurrency` support process-limited number of CPUs Use `libc::sched_getaffinity` and count the number of CPUs in the returned mask. This handles cases where the process doesn't have access to all CPUs, such as when limited via `taskset` or similar. This also covers cgroup cpusets.
bors
added
S-waiting-on-author
|
Fixed the missing macros on Android in rust-lang/libc#2470 . Once that goes in, I'll do a libc release and update. |
joshtriplett
force-pushed
the
available-concurrency-affinity
branch
from
433439e
to
645e46e
Compare
|
@bors r=m-ou-se |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
…r of CPUs Use libc::sched_getaffinity and count the number of CPUs in the returned mask. This handles cases where the process doesn't have access to all CPUs, such as when limited via taskset or similar.
joshtriplett
force-pushed
the
available-concurrency-affinity
branch
from
645e46e
to
7c9611d
Compare
|
Updated to libc 0.2.106 which includes the fix for the issue that broke CI on macOS. @bors r=m-ou-se |
|
📌 Commit 7c9611d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7c9611d with merge bd73825db1627e06ead2c3e17513f3aaa9b2c46d... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 7c9611d has been approved by |
bors
added
S-waiting-on-bors
|
@bors retry |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (fecfc0e): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
libc::sched_getaffinityand count the number of CPUs in the returned mask. This handles cases where the process doesn't have access to all CPUs, such as when limited viatasksetor similar.This also covers cgroup cpusets.