Move generic error message to separate branches #89317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
JulianKnodt
force-pushed
the
precise_errors
branch
from
ec87784 to
c5f3662
Compare
This comment has been minimized.
This comment has been minimized.
BoxyUwU
requested changes
Sep 28, 2021
JulianKnodt
force-pushed
the
precise_errors
branch
from
c5f3662 to
11b40b2
Compare
This comment has been minimized.
This comment has been minimized.
JulianKnodt
force-pushed
the
precise_errors
branch
from
11b40b2 to
0f7ea0c
Compare
This comment has been minimized.
This comment has been minimized.
JulianKnodt
force-pushed
the
precise_errors
branch
from
0f7ea0c to
9e3a104
Compare
JulianKnodt
force-pushed
the
precise_errors
branch
from
9e3a104 to
92d4e9f
Compare
BoxyUwU
requested changes
Oct 4, 2021
This decomposes an error message in generic constants into more specific branches, for better readability.
JulianKnodt
force-pushed
the
precise_errors
branch
from
92d4e9f to
9cb30f4
Compare
|
@bors r+ |
|
📌 Commit 9cb30f4 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 5, 2021
Move generic error message to separate branches This decomposes an error message in generic constants into more specific branches, for better readability. r? `@lcnr`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2021
…arth Rollup of 10 pull requests Successful merges: - rust-lang#88706 (Normalize associated type projections when checking return type of main) - rust-lang#88828 (Use `libc::sigaction()` instead of `sys::signal()` to prevent a deadlock) - rust-lang#88871 (Fix suggestion for nested struct patterns) - rust-lang#89317 (Move generic error message to separate branches) - rust-lang#89351 (for signed wrapping remainder, do not compare lhs with MIN) - rust-lang#89442 (Add check for duplicated doc aliases) - rust-lang#89502 (Fix Lower/UpperExp formatting for integers and precision zero) - rust-lang#89523 (Make `proc_macro_derive_resolution_fallback` a future-breakage lint) - rust-lang#89532 (Document behavior of `MaybeLiveLocals` regarding enums and field-senstivity) - rust-lang#89546 (Make an initial guess for metadata size to reduce buffer resizes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
lcnr
added
A-const-generics
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decomposes an error message in generic constants into more specific branches, for better
readability.
r? @lcnr