Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows LLVM issue. #89380

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Fix Windows LLVM issue. #89380

merged 1 commit into from
Sep 30, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 29, 2021

GitHub image 20210928.2 added LLVM 12.0.1 to the stock image. However, the lldb executable doesn't work, it fails with:

C:/Program Files/LLVM/bin/lldb.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

We probably don't want to start testing LLDB on windows anyways (at least not without intent).

The hacky solution for now is to just delete the system LLVM.

@rust-highfive
Copy link
Collaborator

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Sep 29, 2021

Some alternate solutions could be:

  • Remove C:\Program Files\LLVM\bin from PATH. I don't know how to do that in a safe way in GitHub Actions.
  • Add an option to rustbuild to explicitly ignore lldb.
  • Change rustbuild to behave as-if lldb isn't installed if lldb -P fails.

@Mark-Simulacrum
Copy link
Member

I think this is the right solution for now.

@bors r+ p=101

@bors
Copy link
Contributor

bors commented Sep 29, 2021

📌 Commit 0f47312 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Sep 29, 2021

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2021
@bors
Copy link
Contributor

bors commented Sep 29, 2021

⌛ Testing commit 0f47312 with merge 24a789b...

@bors
Copy link
Contributor

bors commented Sep 30, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 24a789b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 30, 2021
@bors bors merged commit 24a789b into rust-lang:master Sep 30, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 30, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (24a789b): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

ehuss pushed a commit to ehuss/rust that referenced this pull request Oct 4, 2021
@bors @ehuss
Auto merge of rust-lang#89380 - ehuss:fix-windows-llvm, r=Mark-Simula…
06b37f1 
…crum

Fix Windows LLVM issue.

GitHub image 20210928.2 added LLVM 12.0.1 to the stock image.  However, the `lldb` executable doesn't work, it fails with:

> C:/Program Files/LLVM/bin/lldb.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

We probably don't want to start testing LLDB on windows anyways (at least not without intent).

The hacky solution for now is to just delete the system LLVM.
@ehuss ehuss mentioned this pull request Oct 4, 2021
Merged
@ehuss ehuss added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 4, 2021
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.57.0, 1.56.0 Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ehuss @rust-highfive @Mark-Simulacrum @bors @rust-timer @pietroalbini @rustbot