-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: use slice::contains instead of open-coding it #89444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 1, 2021
GuillaumeGomez
approved these changes
Oct 1, 2021
Thanks! r=me once CI pass. |
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/contains-str
branch
from
October 1, 2021 20:16
78743c1
to
dd02a38
Compare
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/contains-str
branch
from
October 1, 2021 20:58
dd02a38
to
55bb0af
Compare
cuviper
reviewed
Oct 1, 2021
notriddle
changed the title
rustdoc: use Itertools::contains instead of open-coding it
rustdoc: use slice::contains instead of open-coding it
Oct 1, 2021
notriddle
force-pushed
the
notriddle/contains-str
branch
from
October 1, 2021 23:42
55bb0af
to
277a018
Compare
Sorry about that. I probably should've noticed that |
@bors r+ rollup |
📌 Commit 277a018 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 2, 2021
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 3, 2021
…=jyn514 rustdoc: use slice::contains instead of open-coding it
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 4, 2021
…=jyn514 rustdoc: use slice::contains instead of open-coding it
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 4, 2021
…=jyn514 rustdoc: use slice::contains instead of open-coding it
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2021
…ingjubilee Rollup of 13 pull requests Successful merges: - rust-lang#83655 ([aarch64] add target feature outline-atomics) - rust-lang#87091 (implement advance_(back_)_by on more iterators) - rust-lang#88451 (Fix an ICE caused by type mismatch errors being ignored) - rust-lang#88452 (VecDeque: improve performance for From<[T; N]>) - rust-lang#89400 (Improve wording of `map_or_else` docs) - rust-lang#89407 (Recommend running `cargo clean` in E0514 output) - rust-lang#89443 (Include the length in BTree hashes) - rust-lang#89444 (rustdoc: use slice::contains instead of open-coding it) - rust-lang#89447 (Improve error message for missing angle brackets in `[_]::method`) - rust-lang#89453 (Consistently use 'supertrait'.) - rust-lang#89483 (Practice diagnostic message convention) - rust-lang#89500 (Fix ICE with buffered lint referring to AST node deleted by everybody_loops) - rust-lang#89508 (Stabilize `const_panic`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.