-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct edition for panic in [debug_]assert!(). #89622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ou-se
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
A-edition-2021
Area: The 2021 edition
labels
Oct 7, 2021
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 7, 2021
m-ou-se
force-pushed
the
debug-assert-2021
branch
from
October 7, 2021 12:13
a30f18d
to
a9b33be
Compare
m-ou-se
changed the title
Use correct edition for panic in debug_assert!().
Use correct edition for panic in [debug_]assert!().
Oct 7, 2021
m-ou-se
force-pushed
the
debug-assert-2021
branch
2 times, most recently
from
October 7, 2021 12:21
58a1352
to
3c7af31
Compare
m-ou-se
force-pushed
the
debug-assert-2021
branch
from
October 7, 2021 12:27
3c7af31
to
fcd9fa9
Compare
@bors r+ |
📌 Commit fcd9fa9 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 7, 2021
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 7, 2021
Use correct edition for panic in [debug_]assert!(). See rust-lang#88638 (comment)
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 8, 2021
Use correct edition for panic in [debug_]assert!(). See rust-lang#88638 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2021
…ingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#87918 (Enable AutoFDO.) - rust-lang#88137 (On macOS, make strip="symbols" not pass any options to strip) - rust-lang#88772 (Fixed confusing wording on Result::map_or_else.) - rust-lang#89025 (Implement `#[link_ordinal(n)]`) - rust-lang#89082 (Implement rust-lang#85440 (Random test ordering)) - rust-lang#89288 (Wrapper for `-Z gcc-ld=lld` to invoke rust-lld with the correct flavor) - rust-lang#89476 (Correct decoding of foreign expansions during incr. comp.) - rust-lang#89622 (Use correct edition for panic in [debug_]assert!().) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustbot
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
Oct 14, 2021
Mark-Simulacrum
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Oct 14, 2021
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2021
[beta] backports - 2229: Consume IfLet expr rust-lang#89282 - Wrapper for -Z gcc-ld=lld to invoke rust-lld with the correct flavor rust-lang#89288 - Fix unsound optimization with explicit variant discriminants rust-lang#89489 - Fix stabilization version for bindings_after_at rust-lang#89605 - Turn vtable_allocation() into a query rust-lang#89619 - Revert "Stabilize Iterator::intersperse()" rust-lang#89638 - Ignore type of projections for upvar capturing rust-lang#89648 - ~~Add Poll::ready and~~ revert stabilization of task::ready! rust-lang#89651 - CI: Use mirror for libisl downloads for more docker dist builds rust-lang#89661 - Use correct edition for panic in [debug_]assert!(). rust-lang#89622 - Switch to our own mirror of libisl plus ct-ng oldconfig fixes rust-lang#89599 - Emit item no type error even if type inference fails rust-lang#89585 - Revert enum discriminants rust-lang#89884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-edition-2021
Area: The 2021 edition
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #88638 (comment)