-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation to boxed conversions #89664
Merged
bors
merged 3 commits into
rust-lang:master
from
timClicks:51430-document-boxed-conversions
Oct 9, 2021
Merged
Add documentation to boxed conversions #89664
bors
merged 3 commits into
rust-lang:master
from
timClicks:51430-document-boxed-conversions
Oct 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Among other changes, documents whether allocations are necessary to complete the type conversion. Part of rust-lang#51430 Co-authored-by: Giacomo Stevanato <giaco.stevanato@gmail.com> Co-authored-by: Joshua Nelson <github@jyn.dev>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 8, 2021
lnicola
reviewed
Oct 8, 2021
joshtriplett
reviewed
Oct 9, 2021
joshtriplett
reviewed
Oct 9, 2021
Thank you @lnicola and @joshtriplett for your close reads. |
timClicks
commented
Oct 9, 2021
Co-authored-by: Josh Triplett <josh@joshtriplett.org> Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
lnicola
reviewed
Oct 9, 2021
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
Thanks! @bors r+ rollup |
📌 Commit 020ec0a has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 9, 2021
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 9, 2021
…ersions, r=m-ou-se Add documentation to boxed conversions Among other changes, documents whether allocations are necessary to complete the type conversion. Part of rust-lang#51430, supersedes rust-lang#89199
This was referenced Oct 9, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 9, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#75644 (Add 'core::array::from_fn' and 'core::array::try_from_fn') - rust-lang#87528 (stack overflow handler specific openbsd change.) - rust-lang#88436 (std: Stabilize command_access) - rust-lang#89614 (Update to Unicode 14.0) - rust-lang#89664 (Add documentation to boxed conversions) - rust-lang#89700 (Fix invalid HTML generation for higher bounds) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other changes, documents whether allocations are necessary
to complete the type conversion.
Part of #51430, supersedes #89199