Skip to content

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Oct 9, 2021

Part of #84419.

This moves the first line of each item page (E.g. Struct foo::Bar .... 1.0.0 [-][src] into a Tera template.

I also moved template initialization into its own module and added a small macro to reduce duplication and opportunity for errors.

jsha added 2 commits October 8, 2021 23:02
Add print_item.html and the code in print_item.rs to use it.
@jsha jsha added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Oct 9, 2021
@jsha jsha requested a review from GuillaumeGomez October 9, 2021 06:56
@rust-highfive
Copy link
Contributor

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2021
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

Thanks for the PR and the answers!

r=me once CI pass

@jsha
Copy link
Contributor Author

jsha commented Oct 9, 2021

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Oct 9, 2021

📌 Commit d0a33fb has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2021
@GuillaumeGomez
Copy link
Member

Since it can impact performance, let's not put it into the rollup.

@bors: rollup=iffy

@bors
Copy link
Collaborator

bors commented Oct 10, 2021

⌛ Testing commit d0a33fb with merge c1cb974...

@bors
Copy link
Collaborator

bors commented Oct 10, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing c1cb974 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 10, 2021
@bors bors merged commit c1cb974 into rust-lang:master Oct 10, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 10, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c1cb974): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 3.7% on full builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Oct 10, 2021
@GuillaumeGomez
Copy link
Member

@jsha: It's a big regression for doc build time... Time for optimization I guess. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants