Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #89752

Merged
merged 16 commits into from
Oct 11, 2021
Merged

Rollup of 6 pull requests #89752

merged 16 commits into from
Oct 11, 2021

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

clemenswasser and others added 16 commits October 9, 2021 18:56
…8, r=Mark-Simulacrum

Add regression test for issue 80108

Closes rust-lang#80108
…=Mark-Simulacrum

Move `DebuggerCommands` and `check_debugger_output` to a separate module

Work towards rust-lang#89475.

As part of this move, the public functions were changed to return `Result`. This is so that the error handling that initially took `&self: TestCx` can still use that `TestCx`.
…ons, r=Mark-Simulacrum

Apply clippy suggestions for std
…iplett

Fix spelling: Cannonical -> Canonical
…r=dns2utf8

Remove unused CSS rule

As you can see in the firefox devtools:

![Screenshot from 2021-10-10 14-28-08](https://user-images.githubusercontent.com/3050060/136695689-16c77ceb-b1ab-40df-963a-048f2258e217.png)

It needs the display to be `grid` or `inline-grid`, which isn't the case.

r? `@dns2utf8`
@rustbot rustbot added the rollup A PR which is a rollup label Oct 10, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Oct 10, 2021

📌 Commit bf01a59 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 10, 2021
@bors
Copy link
Contributor

bors commented Oct 11, 2021

⌛ Testing commit bf01a59 with merge 1ddd4e6...

@camelid
Copy link
Member

camelid commented Oct 11, 2021

@bors rollup=never

@bors
Copy link
Contributor

bors commented Oct 11, 2021

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 1ddd4e6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 11, 2021
@bors bors merged commit 1ddd4e6 into rust-lang:master Oct 11, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 11, 2021
@bors bors mentioned this pull request Oct 11, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1ddd4e6): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@matthiaskrgr matthiaskrgr deleted the rollup-v4fgmwg branch November 20, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants